Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Remove an unused variable 'channel' #4725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 21, 2021
Merged

Remove an unused variable 'channel' #4725

merged 1 commit into from
Jan 21, 2021

Conversation

estshorter
Copy link
Contributor

@estshorter estshorter commented Jan 16, 2021 •
edited
Loading

I fixed the following compilation warning.

C:\Users\estshorter\.platformio\packages\framework-arduinoespressif32\cores\esp32\esp32-hal-rmt.c: In function 'rmtLoop':
C:\Users\estshorter\.platformio\packages\framework-arduinoespressif32\cores\esp32\esp32-hal-rmt.c:244:9: warning: unused variable 'channel' [-Wunused-variable]
     int channel = rmt->channel;
         ^

Note: This is already fixed in the idf-release/v4.0 and idf-release/v4.2 branches.

arduino-esp32/cores/esp32/esp32-hal-rmt.c

Lines 237 to 249 in d011dd7

bool rmtLoop(rmt_obj_t* rmt, rmt_data_t* data, size_t size)
{
if (!rmt) {
return false;
}
int allocated_size = MAX_DATA_PER_CHANNEL * rmt->buffers;
if (size > allocated_size) {
return false;
}
return _rmtSendOnce(rmt, data, size, true);
}

@me-no-dev me-no-dev merged commit 55442a0 into espressif:master Jan 21, 2021
@estshorter estshorter deleted the fix_unused_variable branch January 21, 2021 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@estshorter @me-no-dev
Morty Proxy This is a proxified and sanitized view of the page, visit original site.