Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Added isKey method to Preferences #4441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 3, 2020
Merged

Added isKey method to Preferences #4441

merged 6 commits into from
Nov 3, 2020

Conversation

lbernstone
Copy link
Contributor

Checks to see if a string is a key in the namespace. Fixes #4440

libraries/Preferences/src/Preferences.cpp Outdated Show resolved Hide resolved
@me-no-dev
Copy link
Member

you know what I'm thinking? :D Since you have that whole if tree, maybe change that function to return item type (enum) and then implement isKey again, by checking if the returned type is valid.

What do you think?

@lbernstone
Copy link
Contributor Author

lbernstone commented Nov 2, 2020

Can you give me an example of what you want the elements to look like? Save some back and forth...

@me-no-dev
Copy link
Member

your branch is writable, I'll just do it :)

@me-no-dev
Copy link
Member

done :)

@me-no-dev me-no-dev merged commit e2452c0 into espressif:master Nov 3, 2020
@lbernstone lbernstone deleted the Prefs_isKey branch November 4, 2020 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request. In Preferences library expose ability to check if a key exists already
3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.