From 2786c64ac613fdbdc965281171b4d60191ef7558 Mon Sep 17 00:00:00 2001 From: full-stack-ex <10585682+full-stack-ex@users.noreply.github.com> Date: Wed, 4 Sep 2019 17:20:05 +0400 Subject: [PATCH 1/2] Fix long Ticker period conversion --- libraries/Ticker/src/Ticker.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libraries/Ticker/src/Ticker.cpp b/libraries/Ticker/src/Ticker.cpp index ce5cf69332c..c89d8afdb5b 100644 --- a/libraries/Ticker/src/Ticker.cpp +++ b/libraries/Ticker/src/Ticker.cpp @@ -43,9 +43,9 @@ void Ticker::_attach_ms(uint32_t milliseconds, bool repeat, callback_with_arg_t } esp_timer_create(&_timerConfig, &_timer); if (repeat) { - esp_timer_start_periodic(_timer, milliseconds * 1000); + esp_timer_start_periodic(_timer, ((uint64_t)milliseconds) * 1000); } else { - esp_timer_start_once(_timer, milliseconds * 1000); + esp_timer_start_once(_timer, ((uint64_t)milliseconds) * 1000); } } From 0b823bef0dc9a7d6fb8b6ac9857a091c4a7f6e58 Mon Sep 17 00:00:00 2001 From: full-stack-ex <10585682+full-stack-ex@users.noreply.github.com> Date: Wed, 4 Sep 2019 18:40:26 +0400 Subject: [PATCH 2/2] Simplify long Ticker period conversion fix by using 1000ULL --- libraries/Ticker/src/Ticker.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libraries/Ticker/src/Ticker.cpp b/libraries/Ticker/src/Ticker.cpp index c89d8afdb5b..1deeb7fb69f 100644 --- a/libraries/Ticker/src/Ticker.cpp +++ b/libraries/Ticker/src/Ticker.cpp @@ -43,9 +43,9 @@ void Ticker::_attach_ms(uint32_t milliseconds, bool repeat, callback_with_arg_t } esp_timer_create(&_timerConfig, &_timer); if (repeat) { - esp_timer_start_periodic(_timer, ((uint64_t)milliseconds) * 1000); + esp_timer_start_periodic(_timer, milliseconds * 1000ULL); } else { - esp_timer_start_once(_timer, ((uint64_t)milliseconds) * 1000); + esp_timer_start_once(_timer, milliseconds * 1000ULL); } }