Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 62c7038

Browse filesBrowse files
yeonjuanbtmills
authored andcommitted
Fix: invalid token checking in computed-property-spacing (fixes #12198) (#12533)
* Fix: invalid token checking in computed-property-spacing (fixes #12198) * Add more test cases
1 parent 4f8a1ee commit 62c7038
Copy full SHA for 62c7038

File tree

Expand file treeCollapse file tree

2 files changed

+397
-4
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

2 files changed

+397
-4
lines changed
Open diff view settings
Collapse file

‎lib/rules/computed-property-spacing.js‎

Copy file name to clipboardExpand all lines: lib/rules/computed-property-spacing.js
+4-4Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -153,10 +153,10 @@ module.exports = {
153153

154154
const property = node[propertyName];
155155

156-
const before = sourceCode.getTokenBefore(property),
157-
first = sourceCode.getFirstToken(property),
158-
last = sourceCode.getLastToken(property),
159-
after = sourceCode.getTokenAfter(property);
156+
const before = sourceCode.getTokenBefore(property, astUtils.isOpeningBracketToken),
157+
first = sourceCode.getTokenAfter(before, { includeComments: true }),
158+
after = sourceCode.getTokenAfter(property, astUtils.isClosingBracketToken),
159+
last = sourceCode.getTokenBefore(after, { includeComments: true });
160160

161161
if (astUtils.isTokenOnSameLine(before, first)) {
162162
if (propertyNameMustBeSpaced) {

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.