Allocate at most one empty string on binary:split/3#11066
Open
josevalim wants to merge 1 commit intoerlang:mastererlang/otp:masterfrom
josevalim:jv-optimize-empty-strings-on-splitjosevalim/otp:jv-optimize-empty-strings-on-splitCopy head branch name to clipboard
Open
Allocate at most one empty string on binary:split/3#11066josevalim wants to merge 1 commit intoerlang:mastererlang/otp:masterfrom josevalim:jv-optimize-empty-strings-on-splitjosevalim/otp:jv-optimize-empty-strings-on-splitCopy head branch name to clipboard
josevalim wants to merge 1 commit intoerlang:mastererlang/otp:masterfrom
josevalim:jv-optimize-empty-strings-on-splitjosevalim/otp:jv-optimize-empty-strings-on-splitCopy head branch name to clipboard
Conversation
Contributor
Author
|
I also wonder if it would make sense to introduce <<"">> as a global constant but that's a separate discussion. |
Contributor
CT Test Results 4 files 225 suites 1h 55m 43s ⏱️ Results for commit e8bb33a. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When splitting on a binary which may allocate several empty strings,
we end-up allocating too many copies, and I thought it would be cheap
and easy to optimise for this particular case.