Use fromCodePoint / codePointAt APIs #24356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
approved these changes
May 17, 2025
juj
approved these changes
May 19, 2025
These APIs were added to JS strings long ago now and are supported in all engines specified in our `OLDEST_*` browser versions. They save some code size by avoiding manual UTF-16 <-> UTF-32 conversion, although we still need to worry about correct iteration.
357445b to
69b6e10
Compare
Thanks, all green now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These APIs were added to JS strings long ago now and are supported in all engines specified in our
OLDEST_*browser versions.They save some code size by avoiding manual UTF-16 <-> UTF-32 conversion, although we still need to worry about correct iteration.