[MODULARIZE=instance] Mark file packager as incompatible for now. #24338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dschuff
reviewed
May 15, 2025
| if options.oformat != OFormat.MJS: | ||
| exit_with_error('WASM_ESM_INTEGRATION is only compatible with EM module output format') | ||
| if not settings.EXPORT_ES6: | ||
| exit_with_error('WASM_ESM_INTEGRATION requires EXPORT_ES6') |
There was a problem hiding this comment.
which cases do we implicitly set dependent flags? I guess that has already happened before we get to this point?
There was a problem hiding this comment.
Yes we deliberately do this early up on line 754
dschuff
approved these changes
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.