Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit d2e2e39

Browse filesBrowse files
committed
Easify list by (default) conditions
I found that the current `pygithub3.services.issues.Issue.list_by_repo` implementations does not work. Overriding the default parameters did not seem to work for me. This PR removes the default parameters. The default parameters don't need to be passed.
1 parent 3320973 commit d2e2e39
Copy full SHA for d2e2e39

File tree

Expand file treeCollapse file tree

2 files changed

+4
-13
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

2 files changed

+4
-13
lines changed
Open diff view settings
Collapse file

‎pygithub3/services/issues/__init__.py‎

Copy file name to clipboardExpand all lines: pygithub3/services/issues/__init__.py
+2-9Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,7 @@ def __init__(self, **config):
1717
self.milestones = Milestones(**config)
1818
super(Issue, self).__init__(**config)
1919

20-
def list(self, filter='assigned', state='open', labels='', sort='created',
21-
direction='desc', since=None):
20+
def list(self, **params):
2221
""" List your issues
2322
2423
:param str filter: 'assigned', 'created', 'mentioned' or 'subscribed'
@@ -33,14 +32,10 @@ def list(self, filter='assigned', state='open', labels='', sort='created',
3332
.. warning::
3433
You must be authenticated
3534
"""
36-
params = dict(filter=filter, state=state, labels=labels, sort=sort,
37-
direction=direction)
3835
request = self.request_builder('issues.list')
3936
return self._get_result(request, **params)
4037

41-
def list_by_repo(self, user=None, repo=None, milestone='*', state='open',
42-
assignee='*', mentioned='', labels='', sort='created',
43-
direction='desc', since=None):
38+
def list_by_repo(self, user=None, repo=None, **params):
4439
""" List issues for a repo
4540
4641
:param str milestone: Milestone ID, 'none' or '*'
@@ -57,8 +52,6 @@ def list_by_repo(self, user=None, repo=None, milestone='*', state='open',
5752
.. note::
5853
Remember :ref:`config precedence`
5954
"""
60-
params = dict(milestone=milestone, state=state, assignee=assignee,
61-
mentioned=mentioned, labels=labels, sort=sort, direction=direction)
6255
request = self.make_request('issues.list_by_repo', user=user,
6356
repo=repo)
6457
return self._get_result(request, **params)
Collapse file

‎pygithub3/services/issues/milestones.py‎

Copy file name to clipboardExpand all lines: pygithub3/services/issues/milestones.py
+2-4Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,7 @@ class Milestones(Service):
88
""" Consume `Milestones API
99
<http://developer.github.com/v3/issues/milestones>`_ """
1010

11-
def list(self, user=None, repo=None, state='open', sort='due_date',
12-
direction='desc'):
11+
def list(self, user=None, repo=None, **params):
1312
""" List milestones for a repo
1413
1514
:param str user: Username
@@ -24,8 +23,7 @@ def list(self, user=None, repo=None, state='open', sort='due_date',
2423
"""
2524
request = self.make_request('issues.milestones.list', user=user,
2625
repo=repo)
27-
return self._get_result(request, state=state, sort=sort,
28-
direction=direction)
26+
return self._get_result(request, **params)
2927

3028
def get(self, number, user=None, repo=None):
3129
""" Get a single milestone

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.