Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Update intro slides on exercises #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 26, 2023
Merged

Update intro slides on exercises #93

merged 5 commits into from
Apr 26, 2023

Conversation

edoardob90
Copy link
Member

@edoardob90 edoardob90 commented Apr 24, 2023 •
edited
Loading

Fixes #46

  • Explain input args to solution functions
  • Explain how exercise sessions will be organized

@edoardob90 edoardob90 added this to the May session milestone Apr 25, 2023
@edoardob90 edoardob90 marked this pull request as draft April 25, 2023 11:47
@edoardob90 edoardob90 changed the title Explain input args to solution functions Update intro slides Apr 25, 2023
@edoardob90 edoardob90 changed the title Update intro slides Update intro slides on exercises Apr 25, 2023
@edoardob90 edoardob90 self-assigned this Apr 25, 2023
@edoardob90 edoardob90 marked this pull request as ready for review April 25, 2023 12:15
yakutovicha
yakutovicha requested changes Apr 25, 2023
View reviewed changes
Copy link
Member

@yakutovicha yakutovicha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @edoardob90. I added below a few comments.

Also, shouldn't we remove the Quarto slides annotations from this notebook too?

intro.ipynb Outdated Show resolved Hide resolved
intro.ipynb Outdated Show resolved Hide resolved
@edoardob90
Copy link
Member Author

Thanks, @edoardob90. I added below a few comments.

Also, shouldn't we remove the Quarto slides annotations from this notebook too?

Well, I do want to have slides for the intro, not just a notebook: there's no Python code to evaluate. If you want a notebook, than I'll move the slides stuff under slides/ and leave the notebook without any annotation.

edoardob90 and others added 2 commits April 25, 2023 15:21
@edoardob90 @yakutovicha
Apply suggestions from code review
5d1eeb8 
Co-authored-by: Aliaksandr Yakutovich <yakutovicha@gmail.com>
@edoardob90
Remove annotations; copy notebook with slides
848eb4c
@edoardob90 edoardob90 requested a review from yakutovicha April 25, 2023 15:30
@edoardob90
Copy link
Member Author

Done! ✅

@yakutovicha
Copy link
Member

Well, I do want to have slides for the intro, not just a notebook: there's no Python code to evaluate. If you want a notebook, than I'll move the slides stuff under slides/ and leave the notebook without any annotation.

I think if we want to convert it to a proper introduction notebook, it might make sense.

yakutovicha
yakutovicha approved these changes Apr 26, 2023
View reviewed changes
Copy link
Member

@yakutovicha yakutovicha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

baffelli
baffelli reviewed Apr 26, 2023
View reviewed changes
slides/intro_slides.ipynb Show resolved Hide resolved
baffelli
baffelli reviewed Apr 26, 2023
View reviewed changes
Copy link
Member

@baffelli baffelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested a small change on how to run the cell.

@edoardob90 edoardob90 merged commit 7b55734 into main Apr 26, 2023
@edoardob90 edoardob90 deleted the update/intro-explain-input-is-available branch April 26, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baffelli baffelli baffelli left review comments

@yakutovicha yakutovicha yakutovicha approved these changes

Assignees

@edoardob90 edoardob90

Labels
None yet
Projects
None yet
Milestone
May 2023 session
Development

Successfully merging this pull request may close these issues.

Explain that all needed inputs are already available
3 participants
@edoardob90 @yakutovicha @baffelli
Morty Proxy This is a proxified and sanitized view of the page, visit original site.