-
Notifications
You must be signed in to change notification settings - Fork 31
Fix/64 #92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/64 #92
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor change, for readability
Improved explanation of modulo. Co-authored-by: Edoardo Baldi <edoardob90@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two minor requests.
functional_programming.ipynb
Outdated
@@ -1275,7 +1275,7 @@ | ||
" Hints:\n", | ||
" <ul>\n", | ||
" <li>\n", | ||
" The operator <code>%</code> (modulo) gives the remainder of division. <code>a % k</code> is 0 when a is a multiple of k. \n", | ||
" The operator <code>%</code> (modulo) gives the remainder of division. <code>a % k</code> is 0 when <code>a</code> is a multiple of <code>k</code>. \n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add a link to the "basic datatypes section". Something like this:
For more information, please check the Arithmetic operations with integers in "Basic datatypes".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed with a comment in 12604ab. Unfortunately I cannot add internal link using markdown here, I tried with HTML links but it did not work.
Co-authored-by: Aliaksandr Yakutovich <yakutovicha@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Fixes #64