Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix/64 #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 26, 2023
Merged

Fix/64 #92

merged 7 commits into from
Apr 26, 2023

Conversation

baffelli
Copy link
Member

Fixes #64

Copy link
Member

@edoardob90 edoardob90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor change, for readability

functional_programming.ipynb Outdated Show resolved Hide resolved
Improved explanation of modulo.

Co-authored-by: Edoardo Baldi <edoardob90@gmail.com>
Copy link
Member

@yakutovicha yakutovicha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor requests.

@@ -1275,7 +1275,7 @@
" Hints:\n",
" <ul>\n",
" <li>\n",
" The operator <code>%</code> (modulo) gives the remainder of division. <code>a % k</code> is 0 when a is a multiple of k. \n",
" The operator <code>%</code> (modulo) gives the remainder of division. <code>a % k</code> is 0 when <code>a</code> is a multiple of <code>k</code>. \n",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a link to the "basic datatypes section". Something like this:

For more information, please check the Arithmetic operations with integers in "Basic datatypes".

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed with a comment in 12604ab. Unfortunately I cannot add internal link using markdown here, I tried with HTML links but it did not work.

functional_programming.ipynb Outdated Show resolved Hide resolved
Copy link
Member

@yakutovicha yakutovicha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yakutovicha yakutovicha requested a review from edoardob90 April 26, 2023 18:28
@edoardob90 edoardob90 merged commit fbe6c25 into main Apr 26, 2023
@edoardob90 edoardob90 deleted the fix/64 branch April 26, 2023 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Functional programming: specify whether letters are capitalised or not.
3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.