Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Fixed test of exercise2. #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 25, 2023
Merged

Fixed test of exercise2. #91

merged 2 commits into from
Apr 25, 2023

Conversation

baffelli
Copy link
Member

Fixes #72

@baffelli baffelli requested a review from edoardob90 April 24, 2023 11:35
edoardob90
edoardob90 requested changes Apr 24, 2023
View reviewed changes
Copy link
Member

@edoardob90 edoardob90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the file read as input for the exercise

tutorial/tests/test_input_output.py Outdated Show resolved Hide resolved
@baffelli @edoardob90
Update tutorial/tests/test_input_output.py
a1e2fb1 
Changed file read for the exercise.

Co-authored-by: Edoardo Baldi <edoardob90@gmail.com>
@yakutovicha yakutovicha requested a review from edoardob90 April 25, 2023 09:50
yakutovicha
yakutovicha approved these changes Apr 25, 2023
View reviewed changes
Copy link
Member

@yakutovicha yakutovicha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@edoardob90 edoardob90 merged commit baf18d3 into main Apr 25, 2023
@edoardob90 edoardob90 deleted the fix/72 branch April 25, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edoardob90 edoardob90 edoardob90 approved these changes

@yakutovicha yakutovicha yakutovicha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Input-Output Exercise 2 "Counting Words": Task and Solution appear to be different
3 participants
@baffelli @edoardob90 @yakutovicha
Morty Proxy This is a proxified and sanitized view of the page, visit original site.