Fix broken test module names #294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR addresses broken test module names by replacing dashes with underscores and fixes a Ruff lint error in OOP tests. Additionally, the notebook now reflects an updated Python version.
- Renamed test module names to use underscores.
- Fixed a Ruff lint error in OOP tests.
- Updated the Python version in the notebook.
Comments suppressed due to low confidence (1)
00_intro.ipynb:556
- Ensure that updating the Python interpreter version in the notebook is intentional and that the runtime environment and dependencies are compatible with Python 3.10.17.
"version": "3.10.17"
|
Need to fix the internal links between notebooks before merging. |
|
I never thought of that 🤦 I am sorry! I can take over this PR if you have other things to prioritize |
despadam
approved these changes
May 4, 2025
There was a problem hiding this comment.
Renaming looks good, thanks for taking care of this. I manually checked each notebook to confirm that the test modules are always being loaded correctly.
Also:
- Fixed all internal broken links, similarly to Fix broken test module names #294
- Fixed how
testsuiteandipytestwere being loaded in11_functional_programming.ipynb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aftern #81 the test modules are not found. A Python module's name cannot contain
-, so I renamed everything consistently using underscores. The order is preserved.I also fixed a Ruff lint error from OOP tests.