Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Added intermediate quizes. #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
May 6, 2024
Merged

Added intermediate quizes. #224

merged 21 commits into from
May 6, 2024

Conversation

baffelli
Copy link
Member

Closing #216

@baffelli baffelli linked an issue Apr 19, 2024 that may be closed by this pull request
@baffelli baffelli marked this pull request as ready for review May 2, 2024 06:14
@baffelli baffelli requested a review from despadam May 2, 2024 06:14
Copy link
Member

@yakutovicha yakutovicha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @baffelli, I made a quick pass.

Try to consistently use (or not use) dots in the answers. Sometimes it is "Yes." (with a dot), sometimes "Yes" (without it). Also, the correct answer is not always consistent in this respect (see my comments below).

tutorial/input_output.py Outdated Show resolved Hide resolved
tutorial/input_output.py Outdated Show resolved Hide resolved
tutorial/input_output.py Outdated Show resolved Hide resolved
tutorial/input_output.py Outdated Show resolved Hide resolved
tutorial/input_output.py Outdated Show resolved Hide resolved
tutorial/input_output.py Outdated Show resolved Hide resolved
tutorial/input_output.py Outdated Show resolved Hide resolved
tutorial/input_output.py Show resolved Hide resolved
tutorial/input_output.py Outdated Show resolved Hide resolved
tutorial/tests/testsuite/testsuite.py Outdated Show resolved Hide resolved
baffelli and others added 10 commits May 2, 2024 13:55
Co-authored-by: Aliaksandr Yakutovich <yakutovicha@gmail.com>
Co-authored-by: Aliaksandr Yakutovich <yakutovicha@gmail.com>
Co-authored-by: Aliaksandr Yakutovich <yakutovicha@gmail.com>
Co-authored-by: Aliaksandr Yakutovich <yakutovicha@gmail.com>
Co-authored-by: Aliaksandr Yakutovich <yakutovicha@gmail.com>
Co-authored-by: Aliaksandr Yakutovich <yakutovicha@gmail.com>
@baffelli baffelli requested a review from yakutovicha May 2, 2024 12:05
Copy link
Member

@yakutovicha yakutovicha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more things

tutorial/tests/testsuite/testsuite.py Outdated Show resolved Hide resolved
tutorial/input_output.py Outdated Show resolved Hide resolved
tutorial/input_output.py Outdated Show resolved Hide resolved
tutorial/input_output.py Outdated Show resolved Hide resolved
tutorial/input_output.py Outdated Show resolved Hide resolved
tutorial/input_output.py Outdated Show resolved Hide resolved
tutorial/input_output.py Show resolved Hide resolved
tutorial/input_output.py Outdated Show resolved Hide resolved
tutorial/input_output.py Outdated Show resolved Hide resolved
tutorial/input_output.py Show resolved Hide resolved
@despadam despadam assigned baffelli and unassigned despadam May 2, 2024
@despadam despadam added the upcoming tutorial Stuff to work on/fix before the next tutorial label May 3, 2024
@baffelli baffelli requested a review from yakutovicha May 4, 2024 14:34
@baffelli baffelli dismissed yakutovicha’s stale review May 4, 2024 14:34

Changes done in new commmits

Copy link
Contributor

@despadam despadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Only commented on a couple of typos and missing things

input_output.ipynb Show resolved Hide resolved
input_output.ipynb Outdated Show resolved Hide resolved
input_output.ipynb Outdated Show resolved Hide resolved
input_output.ipynb Outdated Show resolved Hide resolved
baffelli and others added 4 commits May 6, 2024 13:30
Co-authored-by: Despina Adamopoulou <16343312+despadam@users.noreply.github.com>
Co-authored-by: Despina Adamopoulou <16343312+despadam@users.noreply.github.com>
Co-authored-by: Despina Adamopoulou <16343312+despadam@users.noreply.github.com>
@baffelli baffelli requested review from despadam and removed request for yakutovicha May 6, 2024 11:39
@despadam despadam merged commit 93ed886 into main May 6, 2024
1 check passed
@despadam despadam deleted the 216-input-output branch May 6, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upcoming tutorial Stuff to work on/fix before the next tutorial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Input-Output
3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.