Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Manage Python project #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Dec 8, 2023
Merged

Manage Python project #149

merged 14 commits into from
Dec 8, 2023

Conversation

yakutovicha
Copy link
Member

@yakutovicha yakutovicha commented Oct 23, 2023 •
edited
Loading

fixes #12
fixes #124

ToDo:

  • Fix toc.py

@yakutovicha yakutovicha marked this pull request as draft October 23, 2023 12:34
@yakutovicha yakutovicha changed the title Manage Python project notebook Manage Python project Nov 9, 2023
@yakutovicha yakutovicha force-pushed the new-material/package-structure branch from 40c84f2 to 120fb98 Compare December 1, 2023 13:19
@yakutovicha yakutovicha marked this pull request as ready for review December 3, 2023 20:29
@yakutovicha yakutovicha self-assigned this Dec 3, 2023
@yakutovicha yakutovicha removed the request for review from baffelli December 4, 2023 10:25
edoardob90
edoardob90 requested changes Dec 7, 2023
View reviewed changes
Copy link
Member

@edoardob90 edoardob90 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read through it all, and it's great! 🙌🏻

I suggested only a few minor changes that can be approved on-the-fly.

manage_python_project.ipynb Outdated Show resolved Hide resolved
manage_python_project.ipynb Outdated Show resolved Hide resolved
manage_python_project.ipynb Outdated Show resolved Hide resolved
manage_python_project.ipynb Outdated Show resolved Hide resolved
manage_python_project.ipynb Outdated Show resolved Hide resolved
manage_python_project.ipynb Outdated Show resolved Hide resolved
edoardob90
edoardob90 approved these changes Dec 8, 2023
View reviewed changes
Copy link
Member

@edoardob90 edoardob90 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go! 🚀

@yakutovicha yakutovicha merged commit 8570a7e into main Dec 8, 2023
@yakutovicha yakutovicha deleted the new-material/package-structure branch December 8, 2023 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edoardob90 edoardob90 edoardob90 approved these changes

@despadam despadam Awaiting requested review from despadam

Assignees

@yakutovicha yakutovicha

Labels
new material
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Testing Python package structure
2 participants
@yakutovicha @edoardob90
Morty Proxy This is a proxified and sanitized view of the page, visit original site.