new logos for no-window mode #584
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the default emacs logo in no-window mode is ugly.
I made some transparent-background ANSI-art emacs logos with the help of TerminalImageViewer. I did this by just removing the background color, or removing the foreground color and adding the inverse/reverse escape code.
The screenshots above were taken in iTerm2. It looks fine in Windows Console, Windows Terminal, Kitty.
Terminal doesn't support true color, and it displays ascii block characters poorly:
I suspect that the pink around the borders can be fixed. TIV README says:
But I don't see any such setting for Terminal.
mobaxterm has a problem similar to Terminal where it has vertical stripes instead of horizontal. hterm has horizontal and vertical lines.
GNOME Terminal doesn't like a few of the characters, but I bet that can be fixed:
I don't have access to a GUI linux machine with sudo privileges right now to install a bunch of other terminal emulators and take screenshots.
I also did braille:
Note that the artifacts in the lower right are just my shell prompt and cursor on the following line.
After creating these logos, I added them as options for
dashboard-startup-banner, and made it work properly by injectingansi-color-apply-on-regionearly.Since
'logoautomatically switches between image and text logos based on device support, I thought it was natural to do the same for true color / 256 color usingdisplay-color-cells. But since it looks bad on some terminal emulators, I decided against that.I changed the default value for the logo to braille. I think that's a big improvement, but it only works if we are confident that 99% of users have a font installed with braille characters.