consolidate source generation #140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #140 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 47 42 -5
Lines 1457 1425 -32
Branches 235 246 +11
=========================================
- Hits 1457 1425 -32 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves as much logic as possible out of source generator into the build step, which removes lots of duplicated code between the generator and the builder, as well as allows implementing common build preferences affecting bindings in all the assemblies.
Example on using new preferences attribute to make all bindings declared under "Foo.Bar" C# namespace have "Baz" namespace in JavaScript:
Resolves #50, resolves #72.
Breaking changes:
[JSNamespace]attribute. Generated JS namespace is now customized viaSpaceproperty of[JSPreferences]attribute.Globalis no longer prepended to the generated JS namespace when binding's type doesn't have namespace.[JSExport]and[JSImport]attributes, that allowed customizing some of the generated content. Associated behaviour (and more) is now customized via[JSPreferences]attribute.index.mjs.