Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@greg-rychlewski
Copy link
Member

the previous regex created issues for custom adapters because the integration tests are inside the deps directory.

@greg-rychlewski greg-rychlewski merged commit 1fda729 into elixir-ecto:master Jul 1, 2022
@greg-rychlewski
Copy link
Member Author

greg-rychlewski commented Jul 2, 2022

@josevalim I noticed one other thing while trying to help debug the sqlite adapter's integration test failures on the latest Ecto.

Their adapter has to dump booleans to 0/1 which is ok if they belong to a typed field but fails to load properly when for instance they are a value in a map. This is an example of a test that will fail on their adapter:

assert TestRepo.one(from o in Order, select: o.meta["enabled"]) == true (the LHS will be 1)

This made me curious if it would work with embeds, but I noticed that the map values aren't typed even there. I wanted to investigate keeping the type for embed values but before I wasted a lot of time I wanted to see if you knew a reason not to do this. Thanks!

@josevalim
Copy link
Member

From a first glance it makes sense that we should try to keep the type as much as possible. :)

@greg-rychlewski greg-rychlewski deleted the stacktrace_tests branch July 2, 2022 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.