Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@fuelen
Copy link
Contributor

@fuelen fuelen commented May 1, 2022

Hello

Here, Jose mentioned that it would be great to send some improvements present in https://github.com/fuelen/ecto_dev_logger to upstream: phoenixframework/phoenix_ecto#152 (comment)

This is the first patch.

Changes:

  • colorize stacktrace (returning to the original color is not needed, as this is the last part of the string)
  • use : before printing line number, as this format helps editors to open the file at the specified line

@josevalim josevalim merged commit 29c3af3 into elixir-ecto:master May 1, 2022
@josevalim
Copy link
Member

💚 💙 💜 💛 ❤️

@s3cur3 s3cur3 mentioned this pull request May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.