Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@toxa81
Copy link
Collaborator

@toxa81 toxa81 commented Dec 5, 2023

It should be complex, i.e. std::complex<F>, not real.

@toxa81 toxa81 requested a review from gsavva December 5, 2023 10:51
@toxa81 toxa81 self-assigned this Dec 5, 2023
@toxa81 toxa81 added the bug label Dec 5, 2023
@toxa81 toxa81 marked this pull request as ready for review December 5, 2023 13:06
Copy link
Collaborator

@gsavva gsavva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've had instances where this was not failing locally...
I got it. One installation was RelWithDebInfo which enables assertions

@toxa81 toxa81 merged commit 67c7d25 into develop Dec 5, 2023
@toxa81 toxa81 deleted the fix/test_lr_solver branch December 5, 2023 15:08
toxa81 added a commit that referenced this pull request Jan 4, 2024
* [update] bump version; add link to discourse.group (#930)

* [refactor] get rid of template in radial_integrals_sum_L3() (#932)

* apply @simonpintarelli proposed code change

* get rid of one more tempale

* default: -> throw, whitespace

* fix

* apply format

---------

Co-authored-by: Simon Pintarelli <simon.pintarelli@cscs.ch>

* [fix] subspace initialization in test_lr_solver (#934)

* [cmake] remove std::filesystem target (#936)

std::filesystem is part of C++17 which is required via CXX_STANDARD, there is no
need to check for it explicitly

* [fix] compilation error for ~memory_pool+tests (#939)

* Ci/rebuild base image (#942)

* CI: rebuild base images / pin spack to v0.21
* CI: use anonymous environments instead of dev-build with SPEC
* avoid creating partitions with empty intervals in COSTA `custom_layout`



---------

Co-authored-by: Anton Kozhevnikov <toxa81@gmail.com>

* [fix] truncate very small occupation numbers to 0 (#943)

* [refactor] minor cleaups (#938)

* minor cleaups
* apply format

* [cmake] add missing REQUIRED (#945)

* [fix] scalar-relativistic radial solver (#941)

Introduce a few fixes for the scalar-relativistic radial solver.

* [feature] port lr_addusdens to sirius (#937)

Use a different sequence of operations to compute G+q augmentation charge.

---------

Co-authored-by: Simon Pintarelli <simon.pintarelli@cscs.ch>
Co-authored-by: Simon Pintarelli <1237199+simonpintarelli@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.