Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings
This repository was archived by the owner on Jan 6, 2023. It is now read-only.

Upgrade to Chrome 54 #239

Closed
wants to merge 86 commits into from
Closed

Upgrade to Chrome 54 #239

wants to merge 86 commits into from

Conversation

zcbenz
Copy link
Contributor

@zcbenz zcbenz commented Nov 2, 2016 •
edited
Loading

  • Switch to gn
  • Update all the patches
  • Compile on Linux
  • Compile on OS X
  • Compile on Windows
  • Generate distributions on Linux
  • Generate distributions on OS X
  • Generate distributions on Windows
  • Check how to make widevine compile
  • Check everything works with Electron

This was referenced Nov 9, 2016
Closed
Closed
@zcbenz zcbenz force-pushed the chrome54 branch 2 times, most recently from d06f374 to 27cc5fd Compare December 2, 2016 03:35
@kevinsawicki
Copy link
Contributor

Hey @zcbenz, there was an issue on our Linux CI where the logs were too long because of an assertion that was getting logged thousands of times. I fixed it on master in #246 so you may want to rebase/merge that into here to get the libchromiumcontent-linux build working.

@zcbenz zcbenz force-pushed the chrome54 branch 3 times, most recently from 687cf34 to 9e3432b Compare December 12, 2016 03:49
@zcbenz zcbenz force-pushed the chrome54 branch 3 times, most recently from 5f04b18 to e4f8c18 Compare December 14, 2016 12:13
YurySolovyov
YurySolovyov reviewed Dec 14, 2016
View reviewed changes
chromiumcontent/BUILD.gn Outdated
]

if (!is_component_build) {
# Force exposign V8 symbols.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exposing

@zcbenz zcbenz force-pushed the chrome54 branch 2 times, most recently from 899dc74 to 343dc23 Compare December 15, 2016 06:03
poiru
poiru reviewed Dec 15, 2016
View reviewed changes
script/update
args.append('is_component_build=true')
else:
args.append('is_component_build=false is_official_build=true')
args.append('is_component_build=false')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like it could potentially degrade performance. Out of curiosity, how was the libv8_base library corrupted?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would generate LNK1107 error when generating libv8_base.lib, by removing the /GL linker parameter which is added by is_official_build=true, the error is gone.

Chromium does not have this error because v8 is a source_set in it.

@kevinsawicki kevinsawicki mentioned this pull request Dec 21, 2016
Closed
@alespergl alespergl mentioned this pull request Jan 3, 2017
Closed
zcbenz added 23 commits January 6, 2017 09:22
@zcbenz @kevinsawicki
Make toolchain detection on Windows work
5160e19
@zcbenz @kevinsawicki
Do not do official build
00a6684 
It enables whole program optimization, which however generates corrupted
static library for libv8_base on Windows.
@zcbenz @kevinsawicki
Update binary paths for Windows
46dda9e
@zcbenz @kevinsawicki
Fix cibuild not reporting failure on Linux
d431315
@zcbenz @kevinsawicki
ffmpeg.dll.lib should be shipped
ebbb53e
@zcbenz @kevinsawicki
Filter out cpp.lib from win32 distribution
6fed5ab
@zcbenz @kevinsawicki
Ship static libraries from "gen" on Windows
7568764
@zcbenz @kevinsawicki
A few libraries need to be static_library on Windows
5ecf6a3
@zcbenz @kevinsawicki
cpp.lib should be linked for component build
d3a0838
@zcbenz @kevinsawicki
Multiple libraries are named cpp.lib
03c79cf
@zcbenz @kevinsawicki
internal_module should be static_libarry
b87fdf6
@zcbenz @kevinsawicki
Ship a few more necessary libraries for Windows
5ce80e6
@zcbenz @kevinsawicki
Avoid patching content/BUILD.gn
7e746aa
@zcbenz @kevinsawicki
Fix the static build
f51b19a
@zcbenz @kevinsawicki
Fix the patch for MAS build
9242fe0
@zcbenz @kevinsawicki
Location of mksnapshot has changed
4226ffb
@zcbenz @kevinsawicki
Update ct_build_not_timely.patch
b4a48cc
@zcbenz @kevinsawicki
Update dom_key_control.patch
0e4dc91
@zcbenz @kevinsawicki
Put mksnapshot under the root of dist
1033a45
@zcbenz @kevinsawicki
Do not run strip on Windows
689dfbd
@zcbenz @kevinsawicki
sandbox_helper_win.lib should not be filtered out
1fe8d7a
@zcbenz @kevinsawicki
Ship libyuv_neon.a
f4da78b
@zcbenz @kevinsawicki
Fix typo
4d1910b
@demian85
Copy link
Contributor

demian85 commented Jan 9, 2017

Is it safe to build using this branch? #252

@kevinsawicki
Copy link
Contributor

Is it safe to build using this branch?

This branch will (most likely) be merged and released this month in Electron 1.5.0, but there will be releases before that done from master and released as Electron 1.4.x.

So if it is easier to do what you are trying to do against Chrome 54 and that timeline works for you then building against this branch is fine.

@zcbenz
Copy link
Contributor Author

zcbenz commented Jan 17, 2017

Closed in favor of #254.

@zcbenz zcbenz closed this Jan 17, 2017
@zcbenz zcbenz deleted the chrome54 branch January 17, 2017 00:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@poiru poiru poiru left review comments

@YurySolovyov YurySolovyov YurySolovyov left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@zcbenz @kevinsawicki @demian85 @poiru @YurySolovyov @groundwater
Morty Proxy This is a proxified and sanitized view of the page, visit original site.