Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

fix: search for the top-level node_modules folder when using yarn workspaces #902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 12, 2019
Merged

fix: search for the top-level node_modules folder when using yarn workspaces #902

merged 3 commits into from
Jun 12, 2019

Conversation

malept
Copy link
Member

@malept malept commented Jun 1, 2019

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Fixes #869.

@malept malept requested a review from MarshallOfSound June 1, 2019 16:00
@malept
Copy link
Member Author

malept commented Jun 1, 2019

I kind of wonder whether this kind of functionality should actually go into flora-colossus.

@malept malept force-pushed the electron-version-in-yarn-workspaces branch from 7cd6cb6 to a3b11c0 Compare June 1, 2019 16:09
@malept malept merged commit a91d8b3 into master Jun 12, 2019
@malept malept deleted the electron-version-in-yarn-workspaces branch June 12, 2019 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MarshallOfSound MarshallOfSound Awaiting requested review from MarshallOfSound

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

electron-forge does not work with yarn workspaces

1 participant

@malept
Morty Proxy This is a proxified and sanitized view of the page, visit original site.