Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

fix(plugin-webpack): allow port to be configurable #693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 26, 2019
Merged

fix(plugin-webpack): allow port to be configurable #693

merged 2 commits into from
Feb 26, 2019

Conversation

malept
Copy link
Member

@malept malept commented Feb 13, 2019 •
edited
Loading

Summarize your changes:

Allows the webpack plugin config entry port to override the default port number of 3000, as that is a common port for various other dev servers.

This should be added to the v6 docs if merged.

ISSUES CLOSED: #691

@malept malept mentioned this pull request Feb 13, 2019
Closed
3 tasks
MarshallOfSound
MarshallOfSound reviewed Feb 13, 2019
View reviewed changes
Copy link
Member

@MarshallOfSound MarshallOfSound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this should be part of the webpack plugin config as well? 🤔

@malept
Copy link
Member Author

malept commented Feb 13, 2019

Maybe this should be part of the webpack plugin config as well? 🤔

Yep, that works too. I'll fix.

@malept malept force-pushed the configurable-webpack-port branch from fc77d01 to 35a2e68 Compare February 13, 2019 07:40
@malept
Copy link
Member Author

malept commented Feb 13, 2019

Updated.

MarshallOfSound
MarshallOfSound reviewed Feb 13, 2019
View reviewed changes
packages/plugin/webpack/src/WebpackPlugin.ts Show resolved Hide resolved
@MarshallOfSound MarshallOfSound merged commit 4da0230 into master Feb 26, 2019
@MarshallOfSound MarshallOfSound deleted the configurable-webpack-port branch February 26, 2019 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@malept @MarshallOfSound
Morty Proxy This is a proxified and sanitized view of the page, visit original site.