Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Add simple Importer from Forge 5.x to 6.x #653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 9, 2019
Merged

Add simple Importer from Forge 5.x to 6.x #653

merged 5 commits into from
Jan 9, 2019

Conversation

malept
Copy link
Member

@malept malept commented Jan 3, 2019

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Adds support for changing config.forge if it doesn't point to a JS file. In the future we could possibly provide updateForgeConfig for those JS files.

There was some refactoring involved - as a result, getElectronVersion has test coverage.

In general, the feature was written in such a way that it should have complete unit test coverage from a LoC perspective.

@malept malept requested a review from MarshallOfSound January 3, 2019 08:51
@malept malept mentioned this pull request Jan 3, 2019
Closed
22 tasks
@malept
Copy link
Member Author

malept commented Jan 3, 2019

Not sure why Tidelift is failing. It may just need a commit to master to kickstart it.

@malept malept mentioned this pull request Jan 3, 2019
Closed
4 tasks
@malept malept force-pushed the import-5.x-to-6.x branch from 3545b63 to 35077a9 Compare January 8, 2019 16:35
@malept
Copy link
Member Author

malept commented Jan 8, 2019

Electron nightly support was added to this PR because I was already in readElectronVersion.

MarshallOfSound
MarshallOfSound approved these changes Jan 8, 2019
View reviewed changes
Copy link
Member

@MarshallOfSound MarshallOfSound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit

@malept
Copy link
Member Author

malept commented Jan 8, 2019

😆 I need to pick a better electron version in the tests

@malept malept merged commit 1709af0 into master Jan 9, 2019
@malept malept deleted the import-5.x-to-6.x branch January 9, 2019 06:36
@malept malept mentioned this pull request Jan 15, 2019
Closed
3 tasks
@terrellt

This comment has been minimized.

Sign in to view
dsanders11 pushed a commit that referenced this pull request Jan 14, 2023
@codebytere
fix: onbeforeunload triggered for link click (#653)
607a137
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@malept @terrellt @MarshallOfSound
Morty Proxy This is a proxified and sanitized view of the page, visit original site.