Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Typescript :) #495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Apr 28, 2018
Merged

Typescript :) #495

merged 10 commits into from
Apr 28, 2018

Conversation

MarshallOfSound
Copy link
Member

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

See title 😉

@MarshallOfSound
Copy link
Member Author

IMO if the tests pass on all 3 platforms (only ran locally on windows) we should just merge this, far too much to review 😄

@MarshallOfSound MarshallOfSound requested a review from malept April 26, 2018 07:41
@malept
Copy link
Member

malept commented Apr 26, 2018

At least it failed fast 😄

In a future PR, do we want to add tslint?

@MarshallOfSound
Copy link
Member Author

In a future PR, do we want to add tslint?

Yup 👍 Along with adding typedoc to replace esdoc

malept
malept reviewed Apr 27, 2018
View reviewed changes
.vscode/settings.json Outdated
"lifecycle",
"rebuilder"
]
} No newline at end of file
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably should ignore this file.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@MarshallOfSound MarshallOfSound merged commit a3faa61 into master Apr 28, 2018
@MarshallOfSound MarshallOfSound deleted the ts branch April 28, 2018 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malept malept malept approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MarshallOfSound @malept
Morty Proxy This is a proxified and sanitized view of the page, visit original site.