Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

Dexus
Copy link

@Dexus Dexus commented Apr 1, 2025

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

This pull request introduces new configuration options for checksum handling in the PublisherS3 class. The changes primarily focus on allowing users to control checksum calculations and validations for requests and responses to and from S3.

This is local only tested against backblaze S3 and cloudflare R2.

Configuration Enhancements:

  • packages/publisher/s3/src/Config.ts: Added requestChecksumCalculation and responseChecksumValidation options to the PublisherS3Config interface. These options allow users to specify when checksums should be calculated and validated, respectively.

Implementation Updates:

  • packages/publisher/s3/src/PublisherS3.ts: Updated the PublisherS3 class to include the new checksum configuration options when creating the S3 client. Default values are set to "WHEN_SUPPORTED" if not provided.

@Dexus Dexus requested a review from a team as a code owner April 1, 2025 08:29
@Dexus Dexus changed the title Allow modification of ChecksumCalculation fix: Allow modification of ChecksumCalculation Apr 1, 2025
@Dexus Dexus changed the title fix: Allow modification of ChecksumCalculation fix: Publisher S3 add ChecksumCalculation Apr 29, 2025
@Dexus Dexus changed the title fix: Publisher S3 add ChecksumCalculation feat: Publisher S3 add ChecksumCalculation Apr 29, 2025
@Dexus
Copy link
Author

Dexus commented Apr 29, 2025

ping @erickzhao

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Morty Proxy This is a proxified and sanitized view of the page, visit original site.