fix(maker-wix): set default arch #3859
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
erickzhao
approved these changes
Feb 20, 2025
There was a problem hiding this comment.
This LGTM. I think you're right about this being a breaking change, but I think building according to the arch makes the most sense according to how we normally output Forge distributables.
I'm a +1 for this, but only merging after we start the Forge 8 release process.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summarize your changes:
electron-wix-msidefaults tox86arch.Even if
@electron-forgeis set to makex64installer, by defaultx86installer will be created, and the app will be installed toC:\Program Files (x86)\.C:\Program Files\afterC:\Program Files (x86)\).Alternative: maker users can manually pass arch.