Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Fix/cloudflare r2 skip checksum #3808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: main
Choose a base branch
Loading
from
Draft

Fix/cloudflare r2 skip checksum #3808

wants to merge 3 commits into from

Conversation

sebbean
Copy link

@sebbean sebbean commented Jan 20, 2025

Enables pass through for s3RequestChecksumCalculation S3Client option

  publishers: [
    {
      name: '@electron-forge/publisher-s3',
      config: {
        s3RequestChecksumCalculation: 'WHEN_REQUIRED', // cloudflare fix

Can be used to get around Cloudflare R2's lack of checksum support.

An unhandled rejection has occurred inside Forge:
NotImplemented: Header 'x-amz-checksum-algorithm' with value 'CRC32' not implemented
at throwDefaultError (/Users/seb/dev/Streem/slyce-studio-mono/node_modules/.pnpm/@smithy+smithy-client@4.1.2/node_modules/@smithy/smithy-client/dist-cjs/index.js:867:20)
    at /Users/seb/dev/Streem/slyce-studio-mono/node_modules/.pnpm/@smithy+smithy-client@4.1.2/node_modules/@smithy/smithy-client/dist-cjs/index.js:876:5
    at de_CommandError (/Users/seb/dev/Streem/slyce-studio-mono/node_modules/.pnpm/@aws-sdk+client-s3@3.731.1/node_modules/@aws-sdk/client-s3/dist-cjs/index.js:4965:14)
  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@sebbean
Morty Proxy This is a proxified and sanitized view of the page, visit original site.