fix(maker-dmg): Prevent conflict between parallel makers #3519 #3741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarshallOfSound
requested changes
Oct 21, 2024
There was a problem hiding this comment.
I think we should mirror the other makers and do {makeDir}/{makerName}/{platform}/{arch}/{file}
E.g. MakerZIP https://github.com/electron/forge/blob/main/packages/maker/zip/src/MakerZIP.ts#L42
nikwen
reviewed
Oct 29, 2024
| const { createDMG } = require('electron-installer-dmg'); | ||
|
|
||
| const outPath = path.resolve(makeDir, `${this.config.name || appName}.dmg`); | ||
| const dmgName = `${this.config.name || appName}_${targetArch}`; |
There was a problem hiding this comment.
Will this mean that all DMGs will have the arch suffix going forward?
- I'd much prefer my DMGs not to have that extension.
- I assume it would be a breaking change for some people. The way my update server is written, it would break if the DMG name suddenly changes.
IMO it should be configurable whether to have the arch in the file name (if it's even an option at all).
There was a problem hiding this comment.
ok, i will provide a option to enable or not
|
I think I like @MarshallOfSound's approach here but I guess that would be a breaking change for users. Down to merge this when we bump our packages up to Node 22 and have a Forge 8 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summarize your changes: