Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

MarshallOfSound
Copy link
Member

@MarshallOfSound MarshallOfSound commented Oct 30, 2022

This swap does a few cool things:

  • We can now have multiple spinners / progress indicators at the same time
  • We can associate output with a running task (thing piping a spawned process)
  • Tasks are now semantically ordered and we can visually indicate "subtasks"
  • It looks cooler ✨ 😎

This refactor can be done bit-by-bit, this PR tackles the top level checkSystem command and the init + start subcommands. Other commands can be ported ad-hoc with the exception of packager which shouldn't be ported until #3006 lands or is in a state to be cherry-picked.

api/core already depended on listr2 as well so this doesn't add anything to our dependency tree.

Screenshots

Init with template-webpack

image

Start with native module failure

image

Start with plugin-webpack

image

packages/api/cli/src/util/terminate.ts Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.