fix(plugin-webpack): keep devDependencies, dependencies, optionalDependencies and peerDependencies in the distributed package.json
#3007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lDependencies` and `peerDependencies` in the distributed package.json
VerteDinde
approved these changes
Oct 27, 2022
There was a problem hiding this comment.
@erikian Thanks for the PR (and for your prior PRs, we get excited when we see a submission from you! 😄)
|
@VerteDinde thanks, glad to hear it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summarize your changes:
As mentioned in #2818 (comment), the Webpack plugin sets the
devDependencies,dependencies,optionalDependenciesandpeerDependenciesobjects to{}in the distributed package.json. If any other plugin runs after the Webpack plugin and tries to read one of these objects, it will get an empty object instead of the actual dependencies, which seems like an unexpected side-effect.Fixes #2818.