Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

fix(template-typescript-webpack): use new plugin syntax #2989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 25, 2022
Merged

fix(template-typescript-webpack): use new plugin syntax #2989

merged 1 commit into from
Oct 25, 2022

Conversation

georgexu99
Copy link
Contributor

@georgexu99 georgexu99 commented Oct 25, 2022 •
edited by erickzhao
Loading

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

ref #2987

@erickzhao erickzhao changed the title fix: typescript-webpack template config fix(template-typescript-webpack): use new plugin syntax Oct 25, 2022
@codecov
Copy link

codecov bot commented Oct 25, 2022 •
edited
Loading

Codecov Report

Merging #2989 (53355e1) into main (362099a) will decrease coverage by 1.39%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2989      +/-   ##
==========================================
- Coverage   73.80%   72.41%   -1.40%     
==========================================
  Files          66       67       +1     
  Lines        2142     2168      +26     
  Branches      424      436      +12     
==========================================
- Hits         1581     1570      -11     
- Misses        356      399      +43     
+ Partials      205      199       -6
Impacted Files Coverage Δ
...ypescript-webpack/src/TypeScriptWebpackTemplate.ts 100.00% <100.00%> (ø)
packages/maker/squirrel/src/MakerSquirrel.ts 28.57% <0.00%> (-47.62%) ⬇️
packages/maker/wix/src/MakerWix.ts 40.90% <0.00%> (-40.91%) ⬇️
packages/maker/appx/src/MakerAppX.ts 43.10% <0.00%> (-17.25%) ⬇️
packages/plugin/webpack/src/WebpackConfig.ts 94.62% <0.00%> (-4.10%) ⬇️
packages/maker/base/src/Maker.ts 66.66% <0.00%> (-3.04%) ⬇️
packages/api/core/src/util/plugin-interface.ts 31.11% <0.00%> (-0.71%) ⬇️
packages/plugin/webpack/src/WebpackPlugin.ts 37.93% <0.00%> (-0.07%) ⬇️
...kages/plugin/webpack/src/util/rendererTypeUtils.ts 100.00% <0.00%> (ø)
packages/api/core/src/api/make.ts 79.20% <0.00%> (+0.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 362099a...53355e1. Read the comment docs.

@erickzhao erickzhao merged commit 4f222f4 into main Oct 25, 2022
@erickzhao erickzhao deleted the gxu-fix-template branch October 25, 2022 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erickzhao erickzhao erickzhao approved these changes

@VerteDinde VerteDinde Awaiting requested review from VerteDinde

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@georgexu99 @erickzhao
Morty Proxy This is a proxified and sanitized view of the page, visit original site.