fix(docs): only load modules if package has entry point #2981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Samuel Attard <sattard@salesforce.com>
Codecov Report
@@ Coverage Diff @@
## main #2981 +/- ##
==========================================
- Coverage 73.78% 73.36% -0.42%
==========================================
Files 66 66
Lines 2144 2144
Branches 423 423
==========================================
- Hits 1582 1573 -9
Misses 359 359
- Partials 203 212 +9
Continue to review full report at Codecov.
|
MarshallOfSound
approved these changes
Oct 21, 2022
VerteDinde
approved these changes
Oct 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two small fixes:
package.jsonin our utility codemainentry. Removes a warning messageWarning: Could not determine the entry point for "/Users/erick.zhao/Developer/electron/forge/packages/api/cli/package.json". Package will be ignored.