feat!: improve forge configuration DX #2963
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Couple of breaking changes to improve DX * Plugins now follow the same syntax as makers/publishers * Better type safety of the core make/publish APIs * Renamed electronRebuildConfig to rebuildConfig * Fixed types for packagerConfig and rebuildConfig to appropriately Omit certain forge provided keys
Codecov Report
@@ Coverage Diff @@
## main #2963 +/- ##
==========================================
- Coverage 73.46% 73.44% -0.03%
==========================================
Files 67 67
Lines 2178 2180 +2
Branches 427 426 -1
==========================================
+ Hits 1600 1601 +1
- Misses 370 371 +1
Partials 208 208
Continue to review full report at Codecov.
|
georgexu99
approved these changes
Oct 13, 2022
erickzhao
requested changes
Oct 13, 2022
|
this reworks all the plugin docs and changes |
erickzhao
approved these changes
Oct 18, 2022
VerteDinde
approved these changes
Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Couple of breaking changes to improve DX
With better types we can do some work to allow
forge.config.tsand a completely type-safe config 🪄