Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

fix(template-typescript-webpack): preload file to webpack config #2936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 16, 2022
Merged

fix(template-typescript-webpack): preload file to webpack config #2936

merged 3 commits into from
Sep 16, 2022

Conversation

fredrikj31
Copy link
Contributor

@fredrikj31 fredrikj31 commented Sep 14, 2022 •
edited by erickzhao
Loading

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:
I added the preload script to the package.json file, so it would get compiled by Webpack. When you initialize the project it does not work, because the file is not compiled by Webpack. This change would solve this, by adding it to the compiler.

closes #2935

@fredrikj31
Added preload file to json package.
ea8b3dd 
I added the preload script to the package.json file, so it would get compiled by Webpack. When you initialize the project it does not work, because the file is not compiled by Webpack. This change would solve this, by adding it to the compiler.
@codecov
Copy link

codecov bot commented Sep 14, 2022 •
edited
Loading

Codecov Report

Merging #2936 (fea0be7) into master (5264607) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2936      +/-   ##
==========================================
+ Coverage   71.31%   71.32%   +0.01%     
==========================================
  Files          79       79              
  Lines        2412     2413       +1     
  Branches      452      452              
==========================================
+ Hits         1720     1721       +1     
+ Misses        563      469      -94     
- Partials      129      223      +94
Impacted Files Coverage Δ
...ypescript-webpack/src/TypeScriptWebpackTemplate.ts 100.00% <100.00%> (ø)
packages/maker/base/src/Maker.ts 69.69% <0.00%> (ø)
packages/api/core/src/api/make.ts 79.00% <0.00%> (ø)
packages/api/core/src/api/start.ts 64.04% <0.00%> (ø)
packages/api/core/src/util/hook.ts 75.00% <0.00%> (ø)
packages/api/core/src/api/import.ts 61.76% <0.00%> (ø)
packages/api/core/src/api/package.ts 75.55% <0.00%> (ø)
packages/api/core/src/api/publish.ts 68.42% <0.00%> (ø)
packages/api/core/src/util/out-dir.ts 66.66% <0.00%> (ø)
packages/api/core/src/util/parse-archs.ts 60.00% <0.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5264607...fea0be7. Read the comment docs.

@erickzhao erickzhao changed the title Added preload file to json package. fix(template-typescript-webpack): preload file to json package Sep 14, 2022
@erickzhao erickzhao self-requested a review September 14, 2022 22:46
@fredrikj31 @gmreburn
Update packages/template/typescript-webpack/src/TypeScriptWebpackTemp…
8842088 
…late.ts

Co-authored-by: Gregory Reburn <gmreburn@gmail.com>
@fredrikj31 fredrikj31 requested review from gmreburn and removed request for erickzhao September 15, 2022 06:31
@erickzhao erickzhao changed the title fix(template-typescript-webpack): preload file to json package fix(template-typescript-webpack): preload file to webpack config Sep 16, 2022
@fredrikj31
Copy link
Contributor Author

Are we ready to merge it, or is there a couple more checks that needs to be done? @erickzhao @gmreburn

@erickzhao
Copy link
Member

I think it's ready :)

@erickzhao erickzhao merged commit cb1e560 into electron:master Sep 16, 2022
@erickzhao erickzhao mentioned this pull request Sep 19, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BlackHole1 BlackHole1 BlackHole1 approved these changes

@erickzhao erickzhao erickzhao approved these changes

+1 more reviewer

@gmreburn gmreburn gmreburn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Preload script with webpack-typescript template does not load

4 participants

@fredrikj31 @erickzhao @gmreburn @BlackHole1
Morty Proxy This is a proxified and sanitized view of the page, visit original site.