fix(plugin-webpack): throw error if something bad happened in preload compilation #2334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2334 +/- ##
==========================================
- Coverage 73.15% 72.38% -0.78%
==========================================
Files 74 76 +2
Lines 2198 2285 +87
Branches 415 435 +20
==========================================
+ Hits 1608 1654 +46
- Misses 418 471 +53
+ Partials 172 160 -12
Continue to review full report at Codecov.
|
malept
reviewed
Jul 11, 2021
malept
approved these changes
Jul 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summarize your changes:
Do the same as the renderer do, report and exit if all going bad