Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

malept
Copy link
Member

@malept malept commented Jun 18, 2021

Summarize your changes:

Fixes #2331 (probably). At the very least, it allows for a workaround.

This is difficult to test automatically, because it's an option passed to webpack-dev-server.

This needs to be documented in the Webpack plugin guide.

@codecov
Copy link

codecov bot commented Jun 18, 2021

Codecov Report

Merging #2332 (4e5e427) into master (6e0a624) will increase coverage by 2.37%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2332      +/-   ##
==========================================
+ Coverage   73.19%   75.56%   +2.37%     
==========================================
  Files          74       74              
  Lines        2197     2202       +5     
  Branches      414      415       +1     
==========================================
+ Hits         1608     1664      +56     
- Misses        418      421       +3     
+ Partials      171      117      -54     
Impacted Files Coverage Δ
packages/plugin/webpack/src/WebpackPlugin.ts 58.46% <0.00%> (-0.33%) ⬇️
packages/maker/base/src/Maker.ts 75.67% <0.00%> (-2.11%) ⬇️
packages/installer/darwin/src/InstallerDarwin.ts 31.57% <0.00%> (-1.76%) ⬇️
packages/api/core/src/util/upgrade-forge-config.ts 94.73% <0.00%> (-1.70%) ⬇️
packages/api/core/src/api/init.ts 97.05% <0.00%> (+5.88%) ⬆️
packages/api/core/src/api/make.ts 88.29% <0.00%> (+6.57%) ⬆️
packages/api/core/src/util/rebuild.ts 100.00% <0.00%> (+7.14%) ⬆️
packages/api/core/src/api/install.ts 94.87% <0.00%> (+16.66%) ⬆️
packages/api/core/src/api/start.ts 87.34% <0.00%> (+20.25%) ⬆️
packages/api/core/src/api/publish.ts 92.10% <0.00%> (+22.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e0a624...4e5e427. Read the comment docs.

@malept malept merged commit 7d46109 into master Jun 18, 2021
@malept malept deleted the malept/gh-2331/webpack-dev-csp branch June 18, 2021 21:15
packages/plugin/webpack/src/Config.ts Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[webpack] Add a configuration option to set the CSP header during development

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.