Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

malept
Copy link
Member

@malept malept commented Feb 3, 2020

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Last year, it was declared that tslint was going to be deprecated in favor of eslint: https://eslint.org/blog/2019/01/future-typescript-eslint

As of tslint v6.0.0, it has been marked as deprecated: https://www.npmjs.com/package/tslint/v/6.0.0

This PR updates the templates to use the recommended linter, eslint.

@codecov
Copy link

codecov bot commented Feb 3, 2020

Codecov Report

Merging #1467 into master will decrease coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #1467     +/-   ##
=========================================
- Coverage   75.16%   75.07%   -0.1%     
=========================================
  Files          73       73             
  Lines        2130     2130             
  Branches      397      397             
=========================================
- Hits         1601     1599      -2     
- Misses        407      409      +2     
  Partials      122      122
Impacted Files Coverage Δ
...ypescript-webpack/src/TypeScriptWebpackTemplate.ts 100% <100%> (ø) ⬆️
...ages/template/typescript/src/TypeScriptTemplate.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0193c27...4e7bfbf. Read the comment docs.

@malept malept merged commit 37431b3 into master Feb 3, 2020
@malept malept deleted the template-tslint-to-eslint branch February 3, 2020 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Morty Proxy This is a proxified and sanitized view of the page, visit original site.