Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

malept
Copy link
Member

@malept malept commented Jan 29, 2020

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Fixes #1377.

@codecov
Copy link

codecov bot commented Jan 29, 2020

Codecov Report

Merging #1450 into master will increase coverage by 0.09%.
The diff coverage is 90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1450      +/-   ##
==========================================
+ Coverage   75.07%   75.16%   +0.09%     
==========================================
  Files          73       73              
  Lines        2118     2130      +12     
  Branches      394      397       +3     
==========================================
+ Hits         1590     1601      +11     
- Misses        404      405       +1     
  Partials      124      124
Impacted Files Coverage Δ
packages/api/core/src/api/start.ts 87.01% <100%> (ø) ⬆️
packages/api/core/src/util/electron-version.ts 95.23% <88.88%> (-0.85%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c6e233...ef80c56. Read the comment docs.

@malept malept merged commit 8613386 into master Jan 29, 2020
@malept malept deleted the start-yarn-workspace branch January 29, 2020 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

start does not work with yarn workspaces

1 participant

Morty Proxy This is a proxified and sanitized view of the page, visit original site.