Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

malept
Copy link
Member

@malept malept commented Jan 14, 2020

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Splits out the Webpack config generation code to its own file, and adds basic test coverage.

@codecov
Copy link

codecov bot commented Jan 14, 2020

Codecov Report

Merging #1401 into master will decrease coverage by 26.66%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1401       +/-   ##
===========================================
- Coverage    68.5%   41.84%   -26.67%     
===========================================
  Files          72        4       -68     
  Lines        2099      184     -1915     
  Branches      389       37      -352     
===========================================
- Hits         1438       77     -1361     
+ Misses        507       95      -412     
+ Partials      154       12      -142
Impacted Files Coverage Δ
packages/api/core/src/api/import.ts 26.73% <0%> (-32.1%) ⬇️
packages/maker/snap/src/MakerSnap.ts
...es/api/core/src/api/init-scripts/init-directory.ts
packages/api/core/src/util/index.ts
packages/api/core/src/util/publish-state.ts
packages/utils/async-ora/src/index.ts
packages/maker/wix/src/util/author-name.ts
packages/maker/rpm/src/MakerRpm.ts
packages/utils/test-utils/src/index.ts
...ypescript-webpack/src/TypeScriptWebpackTemplate.ts
... and 58 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7519bef...d43e7b9. Read the comment docs.

@malept malept force-pushed the refactor-webpack-config branch from 44706cb to d43e7b9 Compare January 15, 2020 00:34
@malept malept merged commit a7d93bb into master Jan 15, 2020
@malept malept deleted the refactor-webpack-config branch January 15, 2020 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Morty Proxy This is a proxified and sanitized view of the page, visit original site.