Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

malept
Copy link
Member

@malept malept commented Dec 12, 2019

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Fixes #1326.

@codecov
Copy link

codecov bot commented Dec 12, 2019

Codecov Report

Merging #1342 into master will increase coverage by 0.73%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1342      +/-   ##
==========================================
+ Coverage   68.49%   69.23%   +0.73%     
==========================================
  Files          70       70              
  Lines        2038     2041       +3     
  Branches      382      383       +1     
==========================================
+ Hits         1396     1413      +17     
+ Misses        474      453      -21     
- Partials      168      175       +7
Impacted Files Coverage Δ
packages/plugin/webpack/src/WebpackPlugin.ts 34.85% <100%> (+4.18%) ⬆️
packages/api/core/src/api/import.ts 58.41% <0%> (ø) ⬆️
packages/api/core/src/util/electron-version.ts 96.07% <0%> (+11.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51fbf71...bc5ff54. Read the comment docs.

@malept malept merged commit 4db53f8 into master Dec 12, 2019
@malept malept deleted the webpack-null-check-config-forge branch December 12, 2019 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[v6] webpack: delete from non-existant object

1 participant

Morty Proxy This is a proxified and sanitized view of the page, visit original site.