Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

malept
Copy link
Member

@malept malept commented Dec 4, 2019

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

The WiX and Squirrel makers don't handle prerelease information in the version, so we need to handle it in a similar manner to the AppX maker (except not making the user set a flag to normalize the version).

Fixes #1245.

@malept malept merged commit d4e402d into electron:master Dec 4, 2019
@malept malept deleted the fix-nupkg-version branch December 4, 2019 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

v6 doesn't name artifacts correctly for Windows nupgk

1 participant

Morty Proxy This is a proxified and sanitized view of the page, visit original site.