Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Use gn chrome54 #8406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 39 commits into from
Jan 19, 2017
Merged

Use gn chrome54 #8406

merged 39 commits into from
Jan 19, 2017

Conversation

alespergl
Copy link
Contributor

@alespergl alespergl commented Jan 13, 2017 •
edited by kevinsawicki
Loading

Complements libchromiumcontent #254

Fixes #6571
Fixes #7814
Fixes #8062
Fixes #8366
Fixes #8405

@zcbenz
Copy link
Contributor

zcbenz commented Jan 17, 2017

I have rebased this branch on master, ready to merge now.

This was referenced Jan 17, 2017
Closed
Closed
@kevinsawicki kevinsawicki mentioned this pull request Jan 17, 2017
Closed
@kevinsawicki
Copy link
Contributor

Rebased this on top of latest master to pull in #8348

alespergl and others added 23 commits January 19, 2017 09:05
@alespergl @poiru
Adjustments after migrating libchromiumcontent to GN
5b3d0f8
@groundwater @poiru
WIP: chrome 54 update
9716e27
@groundwater @poiru
update atom_browser_client.h
6520396
@zcbenz @poiru
Update brightray and libchromiumcontent to Chrome 54
bdc334d
@zcbenz @poiru
Update files for Chrome 54 API changes
497f5a1
@zcbenz @poiru
Fix linking errors on Mac
93a27fd
@zcbenz @poiru
Fix compilation errors for Linux
88f6f5d
@zcbenz @poiru
Fix linking problem with libgtk2ui
fd2fdb5
@zcbenz @poiru
Fix linking error for x64 Linux build
ebb4c93
@zcbenz @poiru
Update libchromiumcontent for the rebase
af212a9
@zcbenz @poiru
Fix building on Windows
6e0762a
@zcbenz @poiru
Fix linking for Windows
0568fa3
@zcbenz @poiru
Fix building error for arm linux
ec134e7
@zcbenz @poiru
Fix linking for arm build
f2a30af
@zcbenz @poiru
Update to latest libchromiumcontent
20b70b3
@kevinsawicki @poiru
Append form to body before submitting
873e6e5
@kevinsawicki @poiru
Update type to level in debugger message spec
2f26dbf
@kevinsawicki @poiru
Add spec for midi without sysex permission
977680d
@kevinsawicki @poiru
Implement RequestPermissions using request handler
18675cc
@kevinsawicki @poiru
Add spec for denying perm requests when handler is cleared
2f5acfe
@kevinsawicki @poiru
Add failing spec for insertCSS
017df93
@kevinsawicki @poiru
Implement insertCSS on webFrame
d6eb0d6
@kevinsawicki @poiru
Call InspectElement directly on InspectableWebContents
443040e
@poiru
Copy link
Contributor

poiru commented Jan 19, 2017

Fixed compiling Node on Windows (patch upstreamed) and rebased on top of latest master.

@poiru poiru force-pushed the use_gn-chrome54 branch 8 times, most recently from 78b746b to a560df3 Compare January 19, 2017 18:54
@kevinsawicki kevinsawicki merged commit 22b21d0 into master Jan 19, 2017
@kevinsawicki
Copy link
Contributor

Thanks @alespergl and @poiru 🚢 🚢 🚢

Going to release this as a beta 1.5.0 to npm now.

@kevinsawicki kevinsawicki deleted the use_gn-chrome54 branch January 19, 2017 21:41
This was referenced Jan 19, 2017
Closed
Closed
@herrmannplatz
Copy link
Contributor

Great job. Looking forward to give it a try.

@kevinsawicki kevinsawicki mentioned this pull request Jan 19, 2017
Merged
@MarshallOfSound MarshallOfSound mentioned this pull request Jan 21, 2017
Closed
@gregor
Copy link

gregor commented Jan 21, 2017

@kevinsawicki What is the eta for the beta?

@kevinsawicki
Copy link
Contributor

What is the eta for the beta?

We hit a linker error on macOS when building the release builds, we are working on upgrading Xcode versions on CI to resolve this.

Assuming the builds/tests are successful after the upgrade, we will release the beta on Monday or Tuesday.

@kevinsawicki kevinsawicki mentioned this pull request Jan 23, 2017
Closed
@kevinsawicki
Copy link
Contributor

kevinsawicki commented Jan 24, 2017 •
edited
Loading

1.5.0 is now published as a prerelease to npm under the beta tag.

You can install it via npm install electron@1.5.0 or npm install electron@beta, please open new issues for any regressions found.

This was referenced Jan 25, 2017
Merged
Merged
Closed
@rhyek rhyek mentioned this pull request Mar 26, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@alespergl @zcbenz @kevinsawicki @poiru @herrmannplatz @gregor @groundwater
Morty Proxy This is a proxified and sanitized view of the page, visit original site.