-
Notifications
You must be signed in to change notification settings - Fork 16.5k
feat: support dip <-> screen conversion on Linux X11 #46211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c6d9243
to
e75c613
Compare
81f75e4
to
b185eda
Compare
d6ef336
to
ecfb1ef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM on the implementation
ecfb1ef
to
cfec681
Compare
In linux-x64 CI:
|
cfec681
to
16728a9
Compare
This old build error again 😸
Even though it's a simple function, probably best to move the impl into a .cc file. If you do go that route, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
API LGTM
Minor request about clarifying behavior on Wayland.
5b4f975
to
a0f413a
Compare
Release Notes Persisted
|
I was unable to backport this PR to "34-x-y" cleanly; |
I was unable to backport this PR to "35-x-y" cleanly; |
I was unable to backport this PR to "36-x-y" cleanly; |
I have automatically backported this PR to "37-x-y", please check out #46895 |
@deepak1556 has manually backported this PR to "35-x-y", please check out #47124 |
@deepak1556 has manually backported this PR to "36-x-y", please check out #47125 |
feat: support dip <-> screen conversion on Linux
Description of Change
Refs #45848.
Adds support for
screen.dipToScreenPoint(point)
andscreen.screenToDipPoint(point)
on Linux X11. There's currently no support for Wayland as the coordinate system is notably more difficult to reconcile with this.Checklist
npm test
passesRelease Notes
Notes: Added support for
screen.dipToScreenPoint(point)
andscreen.screenToDipPoint(point)
on Linux X11.