perf: don't wait for thumbnails if they were not requested on macOS #46138
+22
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the SCK thumbnail capturer, the first refresh has the list of sources, and the second refresh has the thumbnails. If thumbnails are not needed, only wait for the first refresh.
c183fce to
07392d7
Compare
codebytere
approved these changes
Mar 24, 2025
|
Release Notes Persisted
|
This was referenced Mar 25, 2025
|
I have automatically backported this PR to "35-x-y", please check out #46249 |
|
I have automatically backported this PR to "34-x-y", please check out #46250 |
|
I have automatically backported this PR to "36-x-y", please check out #46251 |
kigh-ota
pushed a commit
to kigh-ota/electron
that referenced
this pull request
Sep 30, 2025
…lectron#46138) When using the SCK thumbnail capturer, the first refresh has the list of sources, and the second refresh has the thumbnails. If thumbnails are not needed, only wait for the first refresh.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
When using the SCK thumbnail capturer, the first refresh has the list of sources, and the second refresh has the thumbnails. If thumbnails are not needed, only wait for the first refresh.
Capturing the thumbnails is slow, so this typically saves several hundred milliseconds.
Context: #41328, #41340
Checklist
npm testpasses (except for some failures which appear to be ordinary flakes)Release Notes
Notes: Improved performance of desktopCapturer.getSources when not requesting thumbnails on macOS.