feat: add BrowserWindow.isSnapped()
#46079
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dc4bd35 to
075335e
Compare
samuelmaddock
approved these changes
Mar 17, 2025
| bool NativeWindowViews::IsSnapped() const { | ||
| #if BUILDFLAG(IS_WIN) | ||
| // IsWindowArranged() is not a part of any header file. | ||
| // https://learn.microsoft.com/en-us/windows/win32/api/winuser/nf-winuser-iswindowarranged |
There was a problem hiding this comment.
Apparently it is in a header file, but may have led to crashes on older systems.
https://chromium-review.googlesource.com/c/chromium/src/+/5976961
Seems fine as is though.
e3cec8e to
05fefc6
Compare
itsananderson
approved these changes
Mar 19, 2025
05fefc6 to
d23d8cb
Compare
|
Release Notes Persisted
|
|
I have automatically backported this PR to "36-x-y", please check out #46226 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR adds the ability for a developer to tell whether a given window has been arranged via Snap on Windows. Snap is becoming more integral to Windows window management and understanding this as a window arrangement similar to maximized or minimized is important for developers showing information to users.
See Windows Documentation for more information.
Checklist
npm testpassesRelease Notes
Notes: Added
BrowserWindow.isSnapped()to indicate whether a given window has been arranged via Snap.