Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

feat: redesign preload APIs #45329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jan 31, 2025
Merged

feat: redesign preload APIs #45329

merged 8 commits into from
Jan 31, 2025

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Jan 24, 2025

Backport of #45230

See that PR for details.

Notes:

  • Redesigned preload script APIs by introducing registerPreloadScript, unregisterPreloadScript, getPreloadScripts on Session.
  • Deprecated getPreloads and setPreloads on Session.

trop bot and others added 8 commits January 24, 2025 02:12
@trop @samuelmaddock
feat: redesign preload APIs
0a84840 
Co-authored-by: Samuel Maddock <samuel.maddock@gmail.com>
@trop @samuelmaddock
docs: remove service-worker mentions for now
d1570e8 
Co-authored-by: Samuel Maddock <samuel.maddock@gmail.com>
@trop @samuelmaddock
fix lint
e86786d 
Co-authored-by: Samuel Maddock <samuel.maddock@gmail.com>
@trop @samuelmaddock
remove service-worker ipc code
87d63ce 
Co-authored-by: Samuel Maddock <samuel.maddock@gmail.com>
@trop @samuelmaddock
add filename
bd96d81 
Co-authored-by: Samuel Maddock <samuel.maddock@gmail.com>
@trop @samuelmaddock
fix: web preferences preload not included
0713c26 
Co-authored-by: Samuel Maddock <samuel.maddock@gmail.com>
@trop @samuelmaddock
fix: missing common init
b9415a9 
Co-authored-by: Samuel Maddock <samuel.maddock@gmail.com>
@trop @samuelmaddock
fix: preload bundle script error
9e72ca9 
Co-authored-by: Samuel Maddock <samuel.maddock@gmail.com>
@trop trop bot requested review from a team as code owners January 24, 2025 02:13
@trop trop bot requested a review from samuelmaddock January 24, 2025 02:13
@trop trop bot mentioned this pull request Jan 24, 2025
Merged
5 tasks
@trop trop bot added 35-x-y backport This is a backport PR backport/requested 🗳 semver/minor backwards-compatible functionality labels Jan 24, 2025
@samuelmaddock samuelmaddock mentioned this pull request Jan 24, 2025
Merged
23 tasks
codebytere
codebytere approved these changes Jan 31, 2025
View reviewed changes
Copy link
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by @electron/wg-releases on Jan 30 2025

@samuelmaddock samuelmaddock merged commit 9d696ce into 35-x-y Jan 31, 2025
61 of 62 checks passed
@samuelmaddock samuelmaddock deleted the trop/35-x-y-bp-feat-redesign-preload-apis-1737684757487 branch January 31, 2025 14:46
@release-clerk
Copy link

release-clerk bot commented Jan 31, 2025

Release Notes Persisted

  • Redesigned preload script APIs by introducing registerPreloadScript, unregisterPreloadScript, getPreloadScripts on Session.
  • Deprecated getPreloads and setPreloads on Session.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@codebytere codebytere codebytere approved these changes

@samuelmaddock samuelmaddock Awaiting requested review from samuelmaddock

Assignees

No one assigned

Labels

35-x-y backport/requested 🗳 backport This is a backport PR semver/minor backwards-compatible functionality

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@codebytere @samuelmaddock
Morty Proxy This is a proxified and sanitized view of the page, visit original site.