feat: add error event for utility process #43774
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e61d4ca to
02e6fee
Compare
02e6fee to
0f45d14
Compare
codebytere
reviewed
Sep 19, 2024
patches/node/feat_expose_report_writing_entrypoint_to_embedders.patch
Outdated
Show resolved
Hide resolved
codebytere
added a commit
to codebytere/node
that referenced
this pull request
Sep 23, 2024
Refs electron/electron#43774 Allows creating Node.js diagnostic reports from Electron signal handlers. Currently used by Utility process to support error event.
codebytere
added a commit
to codebytere/node
that referenced
this pull request
Sep 23, 2024
Refs electron/electron#43774 Allows creating Node.js diagnostic reports from Electron signal handlers. Currently used by Utility process to support error event.
3 tasks
codebytere
approved these changes
Sep 25, 2024
jkleinsc
approved these changes
Sep 26, 2024
ckerr
approved these changes
Sep 27, 2024
|
Release Notes Persisted
|
|
I was unable to backport this PR to "33-x-y" cleanly; |
|
I was unable to backport this PR to "32-x-y" cleanly; |
ckerr
pushed a commit
that referenced
this pull request
Sep 27, 2024
* feat: add error event for utility process * chore: use public report api * chore: fix lint * doc: mark error event as experimental --------- Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
ckerr
added a commit
that referenced
this pull request
Sep 27, 2024
remove #include "electron/mas.h" this header did not exist before c1c8fbf
ckerr
added a commit
that referenced
this pull request
Sep 29, 2024
* feat: add error event for utility process (#43774) * feat: add error event for utility process * chore: use public report api * chore: fix lint * doc: mark error event as experimental --------- Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com> * fixup! feat: add error event for utility process (#43774) remove #include "electron/mas.h" this header did not exist before c1c8fbf --------- Co-authored-by: Robo <hop2deep@gmail.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
yangannyx
pushed a commit
to yangannyx/electron
that referenced
this pull request
Oct 21, 2024
* feat: add error event for utility process * chore: use public report api * chore: fix lint * doc: mark error event as experimental --------- Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
yangannyx
pushed a commit
to yangannyx/electron
that referenced
this pull request
Oct 21, 2024
* feat: add error event for utility process * chore: use public report api * chore: fix lint * doc: mark error event as experimental --------- Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
yangannyx
pushed a commit
to yangannyx/electron
that referenced
this pull request
Oct 21, 2024
* feat: add error event for utility process * chore: use public report api * chore: fix lint * doc: mark error event as experimental --------- Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This enables application to collect additional diagnostic data for telemetry purposes. Primary use case for VSCode is to identify addons loaded by 3rd party extensions in the utility process that could trigger V8 Fatal error due to sandbox violation. Additional details available at https://gist.github.com/deepak1556/ec4a882156855f0d7870a4a7c01758e3
The error event can be extended in future on a need basis to expose other error types that the Node.js report module supports.
Checklist
npm testpassesRelease Notes
Notes: Add error event in utility process to support diagnostic reports on V8 fatal errors