ci: refactor non-maintainer lockfile change check to request changes #42855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelmaddock
approved these changes
Jul 11, 2024
5 tasks
codebytere
approved these changes
Jul 16, 2024
erickzhao
approved these changes
Jul 17, 2024
VerteDinde
approved these changes
Jul 17, 2024
|
No Release Notes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Supersedes #42830.
In practice the original automation added in #42534 to auto-close PRs was too harsh, and there's an unfortunate edge case on GitHub where a closed PR can end up in an unrecoverable state if the user force pushes the branch while it's closed.
This refactors the automation to instead drop a "Request changes" review from the bot with the comment (and a check to ensure it only ever drops one review). Should allow for maintainers to dismiss the bot review in cases where the change is within policy, or a maintainer has committed the lockfile change themselves.
Checklist
Release Notes
Notes: none