feat: support app#login event for utility process net requests #42631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d84a9ce to
c6ab261
Compare
c6ab261 to
143b6d8
Compare
jkleinsc
approved these changes
Aug 13, 2024
449c1d8 to
26eb0ab
Compare
|
Failing test is unrelated, merging. |
|
Release Notes Persisted
|
|
I was unable to backport this PR to "30-x-y" cleanly; |
|
I was unable to backport this PR to "31-x-y" cleanly; |
|
I was unable to backport this PR to "32-x-y" cleanly; |
|
Thanks @jkleinsc for rebasing the PR |
|
@deepak1556 has manually backported this PR to "32-x-y", please check out #43317 |
LeUser111
pushed a commit
to LeUser111/electron
that referenced
this pull request
Feb 11, 2025
…ron#42631) * feat: support app#login event for utility process net requests * chore: address review feedback * GlobalRequestID: Avoid unwanted inlining and narrowing int conversions Refs https://chromium-review.googlesource.com/c/chromium/src/+/5702737
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
With net module support to utility process added via #40017, it is currently not straightforward to handle basic auth. Apps would need to have some sort of boilerplate code from utility process to allow the main process trigger an interactive UI for obtaining the credentials. However, we already have logic obtained from Chromium to support basic auth requests from renderers or service workers via the
app.on('login', ...)event. It would be simpler if apps can opt-in to the same event for requests from utility process as well, this is now possible via a new propertyrespondToAuthRequestsFromMainProcesson theutilityProcess.forkapi.Refs microsoft/vscode#212949
Release Notes
Notes: Add support for responding to auth requests initiated from utility process via
app#loginevent