Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

feat: add navigationHistory.getEntryAtIndex(int index) method #41662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 5, 2024
Merged

feat: add navigationHistory.getEntryAtIndex(int index) method #41662

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3ada70b
feat: add `navigationHistory.getEntryAtIndex(int index)` method (#41577)
alicelovescake Mar 21, 2024
5c4ccd2
test: fix flaky tests by replacing real urls with data urls
alicelovescake Mar 26, 2024
2bc7b2e
test: remove hardcoded url
alicelovescake Mar 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
test: remove hardcoded url
  • Loading branch information
@alicelovescake
alicelovescake committed Apr 4, 2024
commit 2bc7b2e6fead7141ddef2f6e3e8ca93a2f3f2b5c
6 changes: 2 additions & 4 deletions 6 spec/api-web-contents-spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -580,10 +580,8 @@ describe('webContents module', () => {

describe('navigationHistory.getActiveIndex() API', () => {
it('should return valid active index after a single page visit', async () => {
await w.loadURL('https://www.google.com');
w.webContents.on('did-finish-load', async () => {
expect(w.webContents.navigationHistory.getActiveIndex()).to.equal(0);
});
await w.loadURL(urlPage1);
expect(w.webContents.navigationHistory.getActiveIndex()).to.equal(0);
});

it('should return valid active index after a multiple page visits', async () => {
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.